remove compiler warnings for CICE; fix missing j-loop index #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DeniseWorthen
commented
Mar 5, 2024
DeniseWorthen
commented
- fixes Compiler warnings may not be suppressed ufs-community/ufs-weather-model#1984 for CICE component in UFS
- fixes missing j-loop in for 4-d export variables. The export of 4-d variables is unused in UFS. If it were used in other systems, it would only be for case where ungridded dimensions were not being used and when not masking by the land mask or ifraction.
DusanJovic-NOAA
approved these changes
Mar 6, 2024
junwang-noaa
approved these changes
Mar 6, 2024
DeniseWorthen
changed the title
|
4/19 tests fail in GHActions/CICETesting. Do these pass for you on HPC? |
|
I did a test by updating to main and creating a PR, which passed. The feature/nowarn is not up-to-date w/ Consortium/main (that will happen w/ the PIO namelist PR). |
NickSzapiro-NOAA
approved these changes
Mar 6, 2024
|
Hi, @DeniseWorthen , testing is complete on WM PR #2172. Feel free to merge this approved PR. |
DeniseWorthen
added a commit
to DeniseWorthen/CICE
that referenced
this pull request
May 9, 2024
) (CICE-Consortium#944) * fix dummy arguments w/o values * fix missing j-loop in export 4d Resolve compiler warning arising from ice_prescribed_mod due to the intent(out) variable RC not being given an explicit value. This is an operational requirement for NOAA. Fix bug arising from missing j-loop index in ice_import_export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.